Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bump k8s 1.30 #726

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Jun 26, 2024

No description provided.

It's possible to have a race in the VFIsReady function.
vf netdevice can have a default eth0 device name and be the time
we call the netlink syscall to get the device information eth0
can be a different device.

this cause duplicate mac allocation on vf admin mac address

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@SchSeba
Copy link
Collaborator Author

SchSeba commented Jun 26, 2024

/hold

Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions github-actions bot added the hold label Jun 26, 2024
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba SchSeba changed the title Bump k8s 1.30 WIP: Bump k8s 1.30 Jun 26, 2024
@zeeke
Copy link
Member

zeeke commented Jun 26, 2024

Failing end2end test failure relates to:

Device plugin config map field has been renamed from SelectorObj to SelectorObjs.

Please consider updating the test code at test/conformance/tests/test_sriov_operator.go#L1859

[sriov] operator Custom SriovNetworkNodePolicy Configuration ExcludeTopology field is forwarded to the device plugin configuration
/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1855
Waiting for the sriov state to stable
Sriov state is stable
  STEP: Using device eth0 on node opr-k8s2-1-worker-0.opr-k8s2-1.lab @ 06/26/24 10:49:11.611
  [FAILED] in [It] - /root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:2922 @ 06/26/24 10:49:51.487
• [FAILED] [52.111 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Configuration ExcludeTopology [It] field is forwarded to the device plugin configuration
/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1855

  [FAILED] Timed out after 30.001s.
  Expected
      <map[string]string | len:2>: {
          "opr-k8s2-1-worker-0.opr-k8s2-1.lab": "{\"resourceList\":[{\"resourceName\":\"resourceXXX\",\"excludeTopology\":true,\"selectors\":{\"pfNames\":[\"eth0#0-3\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObjs\":null}]}",
          "opr-k8s2-1-worker-1.opr-k8s2-1.lab": "{\"resourceList\":null}",
      }
  to have {key: value} matching
      <map[interface {}]interface {} | len:1>: {
          <string>"opr-k8s2-1-worker-0.opr-k8s2-1.lab": <*matchers.ContainSubstringMatcher | 0xc000e96330>{
              Substr: "{\"resourceName\":\"resourceXXX\",\"excludeTopology\":true,\"selectors\":{\"pfNames\":[\"eth0#0-3\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObj\":null}",
              Args: nil,
          },
      }
  In [It] at: /root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:2922 @ 06/26/24 10:49:51.487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants